Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAN-2158: Adding OpenAPI docs generation #143

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

jacekv
Copy link
Member

@jacekv jacekv commented Nov 8, 2024

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Adding the possibility to generate openapi documentation for the Service Node Rest API endpoints.

Related Tickets & Documents

  • Related Issue #
  • Closes #

QA Instructions

Please replace this line with instructions on how to test your changes.

[optional] Are there any post deployment tasks we need to perform?

@jacekv jacekv self-assigned this Nov 8, 2024
@jacekv
Copy link
Member Author

jacekv commented Nov 8, 2024

Ticket contains a json if you would like to see how ot looks

@jacekv jacekv requested a review from chandraprakash November 8, 2024 17:47
danut13
danut13 previously approved these changes Nov 11, 2024
openapi.py Outdated
data.pop('swagger')
data['servers'] = [{'url': 'https://sn1.testnet.pantos.io'}]

with open("openapi.json", "w") as f:
Copy link
Member

@juanmanuel-tirado juanmanuel-tirado Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a parameter
. Or at least be dumped to a docs folder

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did both - default goes to docs folder and added a parameter in case you want to have it somewhere else.

@jacekv jacekv merged commit 0f6b813 into pantos-io:main Nov 13, 2024
15 checks passed
@jacekv jacekv deleted the feature/PAN-2158-api-docs branch November 13, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants